diff options
| author | RogueAI42 <[email protected]> | 2017-06-11 17:34:38 +1000 |
|---|---|---|
| committer | RogueAI42 <[email protected]> | 2017-06-11 17:38:53 +1000 |
| commit | 107a98686a105468b5f200ebcbd27343c1210ce4 (patch) | |
| tree | f6b8403368ddf0b4be2569c0ac8c237635e7b764 /ShiftOS_TheReturn/AppearanceManager.cs | |
| parent | c3deaa23fffb7011efb2b5b0f7fc3e754d21f600 (diff) | |
| download | shiftos_thereturn-107a98686a105468b5f200ebcbd27343c1210ce4.tar.gz shiftos_thereturn-107a98686a105468b5f200ebcbd27343c1210ce4.tar.bz2 shiftos_thereturn-107a98686a105468b5f200ebcbd27343c1210ce4.zip | |
ReflectMan Saves The Day..............
Refactored every part in the code that used that damn foreach loop.
All assemblies are now loaded on startup into an array, and the
results of GetType() on each are concatenated into another array.
The parts of the code that were loading the assemblies and scanning
them themselves now look to ReflectMan.Types, and all disk I/O is
limited to the first time ReflectMan is accessed. While I was there
I also replaced some other foreach loops with array comprehensions
and such to speed things up - there is a noticeable improvement.
It doesn't seem to have broken anything, but I'd appreciate if
someone could do more stress testing for me.
Diffstat (limited to 'ShiftOS_TheReturn/AppearanceManager.cs')
| -rw-r--r-- | ShiftOS_TheReturn/AppearanceManager.cs | 20 |
1 files changed, 1 insertions, 19 deletions
diff --git a/ShiftOS_TheReturn/AppearanceManager.cs b/ShiftOS_TheReturn/AppearanceManager.cs index e244b77..76060dd 100644 --- a/ShiftOS_TheReturn/AppearanceManager.cs +++ b/ShiftOS_TheReturn/AppearanceManager.cs @@ -58,25 +58,7 @@ namespace ShiftOS.Engine //HEY LETS FIND THE WINDOWS public static IEnumerable<Type> GetAllWindowTypes() { - List<Type> types = new List<Type>(); - foreach(var file in System.IO.Directory.GetFiles(Environment.CurrentDirectory)) - { - // hey if a thing is an exe or a dll show up plz kthx - if(file.EndsWith(".exe") || file.EndsWith(".dll")) - { - try - { - var asm = Assembly.LoadFile(file); - foreach(var type in asm.GetTypes()) - { - if (type.GetInterfaces().Contains(typeof(IShiftOSWindow))) - types.Add(type); - } - } - catch { } - } - } - return types; + return Array.FindAll(ReflectMan.Types, t => t.GetInterfaces().Contains(typeof(IShiftOSWindow))); } // hey you know that window we just made appear? well give it its title |
