ReflectMan Saves The Day..............

Refactored every part in the code that used that damn foreach loop.
All assemblies are now loaded on startup into an array, and the
results of GetType() on each are concatenated into another array.
The parts of the code that were loading the assemblies and scanning
them themselves now look to ReflectMan.Types, and all disk I/O is
limited to the first time ReflectMan is accessed. While I was there
I also replaced some other foreach loops with array comprehensions
and such to speed things up - there is a noticeable improvement.

It doesn't seem to have broken anything, but I'd appreciate if
someone could do more stress testing for me.

1 files changed, 7 insertions, 46 deletions

diff --git a/ShiftOS_TheReturn/AppLauncherDaemon.cs b/ShiftOS_TheReturn/AppLauncherDaemon.cs
index 716a6a3..c259556 100644
--- a/ShiftOS_TheReturn/AppLauncherDaemon.cs
+++ b/ShiftOS_TheReturn/AppLauncherDaemon.cs
@@ -63,55 +63,16 @@ namespace ShiftOS.Engine
         {
             List<LauncherItem> win = new List<LauncherItem>();
             
-            foreach (var asmExec in System.IO.Directory.GetFiles(Environment.CurrentDirectory))
+            foreach (var type in Array.FindAll(ReflectMan.Types, t => t.GetInterfaces().Contains(typeof(IShiftOSWindow)) && Shiftorium.UpgradeAttributesUnlocked(t)))
             {
-                if (asmExec.EndsWith(".dll") | asmExec.EndsWith(".exe"))
-                {
-                    try
-                    {
-                        var asm = Assembly.LoadFrom(asmExec);
-
-                        if (asm.GetReferencedAssemblies().Contains("ShiftOS.Engine") || asm.FullName.Contains("ShiftOS.Engine"))
+                foreach (var attr in type.GetCustomAttributes(false))
+                    if (!(attr is MultiplayerOnlyAttribute && !KernelWatchdog.MudConnected))
+                        if (attr is LauncherAttribute)
                         {
-                            foreach (var type in asm.GetTypes())
-                            {
-                                if (type.GetInterfaces().Contains(typeof(IShiftOSWindow)))
-                                {
-                                    bool isAllowed = true;
-                                    foreach (var attr in type.GetCustomAttributes(false))
-                                    {
-                                        if(attr is MultiplayerOnlyAttribute)
-                                        {
-                                            if(KernelWatchdog.MudConnected == false)
-                                            {
-                                                isAllowed = false;
-
-                                            }
-                                        }
-                                        if (isAllowed == true)
-                                        {
-                                            if (attr is LauncherAttribute)
-                                            {
-                                                if (Shiftorium.UpgradeAttributesUnlocked(type))
-                                                {
-                                                    var launch = attr as LauncherAttribute;
-                                                    if (launch.UpgradeInstalled)
-                                                    {
-                                                        win.Add(new LauncherItem { DisplayData = launch, LaunchType = type });
-                                                    }
-                                                }
-                                            }
-                                        }
-                                    }
-                                }
-                            }
+                            var launch = attr as LauncherAttribute;
+                            if (launch.UpgradeInstalled)
+                                win.Add(new LauncherItem { DisplayData = launch, LaunchType = type });
                         }
-                    }
-                    catch
-                    {
-
-                    }
-                }
             }
 
             foreach(var file in Utils.GetFiles(Paths.GetPath("applauncher")))